Fix GeometryInstance3D Custom AABB assignment in the editor not working #90440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes error spam when changing Custom AABB on a MeshInstance3D that has no Mesh resource assigned yet (which is allowed in the editor). This avoids pitfalls when assigning a custom AABB in a script when loading meshes at runtime.
I've tested this in all rendering methods and it works as expected.
Testing project: test_custom_aabb.zip
Before
An AABB that is too small for the mesh is intentionally used to cull objects earlier than intended, so it makes a difference on screen. Here, the custom AABB is ignored when the scene is loaded due to the bug:
simplescreenrecorder-2024-04-09_19.00.48.mp4
After (this PR)
An AABB that is too small for the mesh is intentionally used to cull objects earlier than intended, so it makes a difference on screen. Here, the custom AABB is being obeyed as expected:
simplescreenrecorder-2024-04-09_19.01.05.mp4