Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of frames in sprites with texture region enabled. #16122

Merged
merged 1 commit into from
May 7, 2018

Conversation

ibrahn
Copy link
Contributor

@ibrahn ibrahn commented Jan 27, 2018

If texture region is enabled on a sprite, Hframes and Vframes will now
divide the selected region into frames.

fixes #16007

@ibrahn
Copy link
Contributor Author

ibrahn commented Jan 27, 2018

An option, if desired behaviour is as described in #16007

Perhaps a possible fix would be to have the HFrames and VFrames subdivide the area selected by the region.

If texture region is enabled on a sprite, Hframes and Vframes will now
divide the selected region into frames.
@ibrahn ibrahn force-pushed the sprite-region-with-frames branch from 03dd791 to 9db767d Compare April 8, 2018 19:13
@ibrahn
Copy link
Contributor Author

ibrahn commented Apr 8, 2018

Rebased and resolved conflict with 5f91713

r_src_rect already fully populated in both region and non-region code paths so issue described in #17262 doesn't occur

@akien-mga
Copy link
Member

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprite animation frames don't work if region rect is enabled
3 participants