Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninitialized data in Sprite::_get_rects() #17262

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Fix uninitialized data in Sprite::_get_rects() #17262

merged 1 commit into from
Mar 5, 2018

Conversation

poke1024
Copy link
Contributor

@poke1024 poke1024 commented Mar 4, 2018

Found this while debugging why sometimes clicking on sprites gives error messages of invalid get_pixel coordinates in the editor.

Note that Rect2() is not nulled, and thus the += in master here is undefined.

@akien-mga akien-mga added this to the 3.1 milestone Mar 5, 2018
@akien-mga akien-mga merged commit 6a6aab4 into godotengine:master Mar 5, 2018
@hpvb
Copy link
Member

hpvb commented Mar 28, 2018

Cherrypicked into 3.0.3

@hpvb hpvb removed the cherrypick label Mar 28, 2018
@ibrahn ibrahn mentioned this pull request Apr 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@poke1024 @hpvb @akien-mga