Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the performance reporting update frequency customizable #18998

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 18, 2018

The default update frequency has been changed from 1000ms to 250ms. This makes FPS counter and monitor updates smoother and more reactive. I couldn't notice any significant performance decreases by lowering the default reporting rate to 250ms, even on a nearly empty project which ran at over 4,000 FPS on my machine.

I had to redesign the FPS counting algorithm after this one so that FPS counting no longer relies on an update frequency of 1000ms.

This implements #2794.

The default update frequency has been changed from 1000ms to 250ms.
@akien-mga akien-mga added this to the 3.1 milestone May 18, 2018
@mhilbrunner mhilbrunner merged commit 16974d8 into godotengine:master May 26, 2018
@akien-mga
Copy link
Member

Would have liked @reduz to review this one before merging, because Main::iteration() is very critical for performance.

@reduz
Copy link
Member

reduz commented May 28, 2018

I reverted this, as this is not the right approach to solve the problem, and all it may cause is game stalls (which are happening already with the remote scene tree).

We learned from the remote scene tree than a different way to send this information over from the debugger is needed, probably from a thread. This needs more research before any of this should be touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants