Make the FPS reported by Engine.get_frames_per_second() smoother
#63356
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaelusV
reviewed
Jul 27, 2022
Calinou
force-pushed
the
smooth-fps-counter
branch
3 times, most recently
from
f0d342e to
8682301
Compare
CaelusV
reviewed
Sep 7, 2022
Calinou
force-pushed
the
smooth-fps-counter
branch
from
8682301 to
342a789
Compare
Calinou
force-pushed
the
smooth-fps-counter
branch
from
342a789 to
cc5a0c2
Compare
Calinou
force-pushed
the
smooth-fps-counter
branch
2 times, most recently
from
8b2b0e6 to
ad72599
Compare
|
Rebased and tested again, it works as expected. I update the MRP in OP. A strange issue occurs now when the engine starts: the reported FPS is negative for a brief period of time. I don't recall this happening previously, despite having made no code changes to the PR itself. This is a video of the MRP being run at 120 FPS, slowed down to 10% so you can see it more easily: negative_fps.mp4This does not occur with the script-based implementation in the MRP. |
|
You probably want to make sure the ratio doesn't exceed 1.0 since you're subtracting it from 1.0 on the line below. |
That does the trick, thanks 🙂 |
This uses an averaging algorithm to smooth out the FPS counter.
Calinou
force-pushed
the
smooth-fps-counter
branch
from
ad72599 to
7826d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an averaging algorithm to smooth out the FPS counter. As a bonus, this also makes the reported FPS value an actual float, rather than returning a float constrained to integer steps.
This also improves the documentation a bit.
This PR can be remade for 3.6 if desired. See also #18998, which is an earlier attempt at providing something like this (with a different formula). The same formula is included in the MRP (but commented out) for reference.
Testing project: test_fps_counter.zip
Press Space to toggle between core and script-based FPS reporting. Use core-based reporting to test this PR (or the current behavior, with a vanilla
masterbuild).Press Up/Down arrows to increase/decrease maximum FPS. Note that it's capped by V-Sync for testing purposes, but you can disable V-Sync in the project settings or run with
--disable-vsyncCLI argument if needed.TODO
frame_timeactually defines (I've also triedprocess_ticksto no avail). - For comparison, the script approach in the MRP does not have this issue.