Fixed error spam in remote debugger #22201
Conversation
|
This godot/editor/script_editor_debugger.cpp Lines 496 to 499 in 5436abe |
|
Ah yes I see, I overlooked that. I'll see what I can do about that. |
|
@dualmatrix You can probably just add a delimeter in the hint string to store both values and then split it up on the other side. |
|
Fixed it while preserving the resource path! |
editor/script_editor_debugger.cpp
Outdated
| if (is_new_object) { | ||
| //don't update.. it's the same, instead refresh | ||
| debugObj->prop_list.push_back(pinfo); | ||
| } | ||
|
|
||
| if (Variant::get_type_name(var.get_type()) == "String") { |
There was a problem hiding this comment.
It would be cleaner to check var.get_type() == Variant::STRING IMO instead of checking the human readable name.
There was a problem hiding this comment.
Yeah thats better, fixed!
|
I'm not convinced by the fix overall, not because it's bad, but because it doesn't improve the existing hacky code that caused the issue in the first place. I'm not familiar with this code but I think it might be possible to find a cleaner way to identify resources that have to be loaded as a path, without abusing either the property hint or the Variant value itself. Input from @Geequlim would be welcome. |
Fixed error spam in remote debugger.
|
Yeah it isn't the cleanest code, but it's at least less hacky/broken than previously where the path was stored where the type of the resource was supposed to be, storing it in var at least kinda makes sense imo. |
|
As you say, that's good enough for now. The debugger protocol might need a cleanup, but as long as it works... :) |
Fixed error spam in remote debugger.
This finally fixes #20365 for real this time.
Big thanks to @willnationsdev for tracking down where it all went wrong.