-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Fix display of programmatically created value in remote inspector #44657
Conversation
Thanks!
It would be great to figure it out on |
yippee, this issue masked quite some problems I had, e.g. overly complex collision shapes... |
I think this should be the equivalent change for diff --git a/scene/debugger/scene_debugger.cpp b/scene/debugger/scene_debugger.cpp
index a1d4adcd41..a46f6a0197 100644
--- a/scene/debugger/scene_debugger.cpp
+++ b/scene/debugger/scene_debugger.cpp
@@ -367,7 +367,7 @@ void SceneDebuggerObject::serialize(Array &r_arr, int p_max_size) {
PropertyHint hint = pi.hint;
String hint_string = pi.hint_string;
- if (!res.is_null()) {
+ if (!res.is_null() && !res->get_path().is_empty()) {
var = res->get_path();
} else { //only send information that can be sent..
int len = 0; //test how big is this to encode |
Cherry-picked for 3.3.1. |
Programmatically created property value (object) were shown as "Empty" in the remote inspector. (See #28353 and #30033.)
The debugger code on master had a huge change, so this PR only targets the 3.2 branch.
p.s. I tried the same approach on master in
SceneDebuggerObject::serialize
(here) and the value is shown as "Object ID: XXXX" correctly. But clicking it does not make the inspector inspect the object. I'm not familiar with the 4.0 code, so I don't know why it happens and whether that's the expected behavior in 4.0.