Range: Fix cases where max was set to or below min value #33908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will now raise an error whenever this happens so that we can fix these situations. `max == min` is not allowed as it could lead to divisions by zero in ratios, and `max < min` doesn't make much sense. Fixes godotengine#33907.
akien-mga
commented
Nov 26, 2019
| @@ -100,6 +100,7 @@ void Range::set_value(double p_val) { | |||
| shared->emit_value_changed(); | |||
| } | |||
| void Range::set_min(double p_min) { | |||
| ERR_FAIL_COND_MSG(p_min >= shared->max, "Range cannot have min value higher or equal to its max value."); | |||
There was a problem hiding this comment.
This wasn't a very good idea as it puts too strict requirements on how to set min and max values. For example, since the default min and max are 0 and 100, this triggers an error:
set_min(256)
set_max(16384)
Since min will be higher than max temporarily. It can be worked around by setting max first, but it's not really intuitive. I'll relax the requirement as it's only a problem in get_as_ratio, which already has a check.
akien-mga
added a commit
that referenced
this pull request
Nov 26, 2019
This wasn't a very good idea as it puts too strict requirements on how to set `min` and `max` values. For example, since the default min and max are 0 and 100, this triggers an error: ``` set_min(256) set_max(16384) ``` Since `min` will be higher than `max` temporarily. It can be worked around by setting max first, but it's not really intuitive. I'll relax the requirement as it's only a problem in `get_as_ratio`, which already has a check. Fix another min == max occurrence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will now raise an error whenever this happens so that we can fix
these situations.
max == minis not allowed as it could lead todivisions by zero in ratios, and
max < mindoesn't make much sense.Fixes #33907.