Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the naming scheme for the GodotPlugin's methods #37174

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Update the naming scheme for the GodotPlugin's methods #37174

merged 1 commit into from
Mar 20, 2020

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Mar 19, 2020

This is done to make them generics in preparation of the vulkan integration.

See #36919 (comment) for context.

@m4gr3d m4gr3d added this to the 4.0 milestone Mar 19, 2020
@m4gr3d m4gr3d requested review from akien-mga and a team March 19, 2020 22:44
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Mar 19, 2020

cc @pouleyKetchoupp

@m4gr3d m4gr3d mentioned this pull request Mar 19, 2020
Merged
@pouleyKetchoupp pouleyKetchoupp mentioned this pull request Mar 19, 2020
Merged
@akien-mga akien-mga merged commit bec9fe2 into godotengine:master Mar 20, 2020
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the make_godot_plugin_callbacks_generic branch March 21, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:plugin
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@m4gr3d @akien-mga