[3.2] Update the naming scheme for the GodotPlugin's methods #37175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the vulkan integration.
m4gr3d
force-pushed
the
make_godot_plugin_callbacks_generic_3.2
branch
from
96be560 to
b995256
Compare
|
@akien-mga ping for this PR! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to make the methods' names more generics to maintain plugin compatibility when Godot 4.0 is ready.
See #36919 (comment) for context.
Note: This PR is slightly different from #37174 since the 3.2 branch doesn't include any vulkan logic/callbacks, hence why a separate PR instead of a cherry-pick.