Using command + comma on macOS as default shortcut for editor settings #38451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request 🙂 Note that this change was done in #38044 already: https://github.com/godotengine/godot/pull/38044/files#diff-b6d74ccf775245adb707953658e4defdR6853-R6857 |
|
Hey @Calinou that's awesome, looks like the PR https://github.com/godotengine/godot/pull/38044/files#diff-b6d74ccf775245adb707953658e4defdR6853-R6857 is focusing master branch, right? I was testing only on 3.2 versions also because of the |
|
@eduardonunesp I didn't notice that, sorry. I guess it makes sense to merge this in the |
Calinou
requested changes
May 4, 2020
bruvzg
approved these changes
May 11, 2020
akien-mga
force-pushed
the
feature/command-comma-preferences
branch
from
329990d to
75f77f7
Compare
|
Squashed commits together and rebased on |
akien-mga
added
the
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a common shortcut on mac for preferences of any application, using the
Commad + ,is a default behavior for mac users#7884