Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static_assert checks where code assumes VARIANT_ARG_MAX == 5 #39053

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Add static_assert checks where code assumes VARIANT_ARG_MAX == 5 #39053

merged 1 commit into from
Jun 19, 2020

Conversation

timoschwarzer
Copy link
Contributor

@timoschwarzer timoschwarzer commented May 25, 2020 •
edited
Loading

This PR adds static_assert checks to all places I could find where the code assumes VARIANT_ARG_MAX to be 5 to prevent regressions should VARIANT_ARG_MAX change in the future.

Thanks to @pouleyKetchoupp for the initial hint! :)

@akien-mga akien-mga merged commit 35414f1 into godotengine:master Jun 19, 2020
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou added this to the 4.0 milestone Jul 6, 2020
@Rubonnek Rubonnek mentioned this pull request Oct 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timoschwarzer @akien-mga @Calinou