Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable script editor smooth scrolling by default due to bugs #42704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 10, 2020

Fixing the bug where smooth scrolling stops working after increasing the physics ticks per second project setting doesn't appear to be trivial. Disabling smooth scrolling by default alleviates the issue for now.

The way the current smooth scrolling algorithm works isn't really conductive to a good user experience anyway – it is purely linear and line-based, rather than per-pixel. It's the first option I disable in Godot's editor, even though I don't disable the equivalent feature in Visual Studio Code 🙂

This partially addresses #28385.

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor labels Oct 10, 2020
@Calinou Calinou added this to the 4.0 milestone Oct 10, 2020
@akien-mga akien-mga requested a review from Paulb23 November 16, 2020 12:06
@akien-mga
Copy link
Member

Disabling a feature due to known bugs is not a good option, as it means those known bugs will likely never be fixed, and thus the feature had better been outright removed.

Why does smooth scrolling use physics processing instead of idle?

@Calinou
Copy link
Member Author

Calinou commented Nov 16, 2020

Why does smooth scrolling use physics processing instead of idle?

Maybe it was done this way to sidestep precision issues when the delta is very low (which can happen if you set the editor to update continuously).

I've tried to look at the issue's source but couldn't find a way to fix it. Maybe this is something @Paulb23 can look at?

@Paulb23
Copy link
Member

Paulb23 commented Nov 19, 2020

Why does smooth scrolling use physics processing instead of idle?

I can't remember why I did this, might be worth trying it with idle.

@FeralBytes
Copy link
Contributor

I actually second disabling this "Feature", it is easily the source of multiple bugs, and whether it is enabled or disabled I can not see any difference, with one exception that the bugs are gone if it is disabled.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Feb 9, 2023
@YuriSizov
Copy link
Contributor

Not seeing any consensus, but I guess we could do this now before 4.0, if there are still bugs. (some input issues have been worked on in the past, so the situation can be different now).

@Calinou
Copy link
Member Author

Calinou commented Feb 9, 2023

Not seeing any consensus, but I guess we could do this now before 4.0, if there are still bugs. (some input issues have been worked on in the past, so the situation can be different now).

Smooth scrolling in the script editor hasn't improved noticeably since 3.x, so this PR is still relevant for 4.0.

@YuriSizov
Copy link
Contributor

YuriSizov commented Feb 9, 2023

Then it needs a rebase :)

Though @akien-mga seems to be concern that disabling this due to bugs is a bad idea, so I dunno.

@Calinou
Copy link
Member Author

Calinou commented Feb 9, 2023

Though @akien-mga seems to be concern that disabling this due to bugs is a bad idea, so I dunno.

It's definitely a band-aid and not an actual fix, but it should improve the user experience a lot. Proper smooth scrolling would be better, but we don't have time for it in 4.0.

Fixing the bug where smooth scrolling stops working after increasing
the physics ticks per second project setting doesn't appear to be trivial.
Disabling smooth scrolling by default alleviates the issue for now.

The way the current smooth scrolling algorithm works isn't really
conductive to a good user experience anyway - it is purely linear
and line-based, rather than per-pixel.
@Calinou Calinou force-pushed the default-disable-script-editor-smooth-scrolling branch from 61c07df to 22e663c Compare February 9, 2023 21:40
@akien-mga
Copy link
Member

Well this hasn't got much feedback or support in 2.5 years, it's a bit late now to merge just before 4.0 stable, we won't have time to get user feedback on whether they actually miss the feature being disabled. We don't hear much complaint about the bugs this aims to workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants