Add a Pause button to the 2D and 3D editor #43011
Conversation
Yeah, as I remember the pretensions for that PR in IRC was: "it was not customizable enough and better to be placed in the menu" and "it takes a valuable space". Perhaps the views are changed from that time... |
I think the current problem at hand is more important than saving a bit of space in the menu. It's making people not use Godot when they could otherwise use it. |
At this point I'd take that pause button over most others, haha. To maybe prevent confusion with the pause scene button on the top right, I'd suggest changing the tool name to "Freeze." I've made a 14x14 icon here: ToolFreeze.zip |
Calinou
force-pushed
the
editor-add-pause-button
branch
from
a60f89c
to
77fd121
Compare
|
@molevision I amended my PR to use the icon you provided, thanks 🙂 |
|
Just a note that I think although pausing might be useful for timelines, a more suitable fix for the problem of constant editor updates might be to have a slight modification to the system for requesting updates. At the moment it is very broad, you request an update in the editor no matter whether this is caused by an animating texture, or something that really needs updating (like an update to the UI). Most of the time speaking for myself on a fanless PC, I don't want these constant updates the moment I use TIME in a shader or somesuch. I'm wondering whether we can change the request_update function to have an argument such as a bool (perhaps with a default) to indicate whether the update is an essential update or not. Then we could have a switch in the UI to turn the non essential updating on and off. I've been meaning to have a look at this but it might be something you might be interested in @Calinou. |
|
Is this likely to make it to 3.2.4? |
Probably not, since 3.2.4 is nearing release. You can still cherry-pick this pull request and build it locally if you need it. |
I haven't ever been able to get Vulkan Godot to work properly on my machine, the viewport is always completely black. Is there some way to build this PR with 3.3? |
You can cherry-pick this PR's commit to the You can also save and apply the |
This can be used to decrease CPU/GPU usage if particles or shaders are being displayed in the editor. This closes godotengine/godot-proposals#942. Co-authored-by: Chaosus <chaosus89@gmail.com>
Calinou
force-pushed
the
editor-add-pause-button
branch
from
77fd121
to
0625244
Compare
|
Rebased and tested again, it works successfully. |
|
Congratulations on the 3.3 release! Can this please make it in to 3.3.1? 😅 (Plus, Vulkan in 4.0 using the MoltenVK backend to access Metal might just make the problem go away, for Mac users at least.) |
|
This can be closed, functionality implemented by #53463. |
Salvaged from #31070. Thanks @Chaosus 🙂
This can be used to decrease CPU/GPU usage if particles or shaders are being displayed in the editor.
Note: Since low-processor usage mode hasn't been reimplemented yet in
master, this won't decrease CPU/GPU usage significantly in themasterbranch, only in3.2if it's backported there.Don't merge yet as pausing will break freelook in the 3D editor and scrolling in the script editor if smooth scrolling is enabled (related to #28385, partially addressed by #42704).
I can make a 3.2 version of this PR once it's ready.
This closes godotengine/godot-proposals#942.
Preview
Freeze icon is at the bottom.