Add support for low-end 3D rendering. #44175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
reviewed
Dec 7, 2020
clayjohn
approved these changes
Dec 7, 2020
akien-mga
reviewed
Dec 7, 2020
| _FORCE_INLINE_ void _add_geometry(InstanceBase *p_instance, uint32_t p_surface, RID p_material, PassMode p_pass_mode, uint32_t p_geometry_index, bool p_using_sdfgi = false); | ||
| _FORCE_INLINE_ void _add_geometry_with_material(InstanceBase *p_instance, uint32_t p_surface, MaterialData *p_material, RID p_material_rid, PassMode p_pass_mode, uint32_t p_geometry_index, bool p_using_sdfgi = false); | ||
|
|
||
| void _fill_render_list(InstanceBase **p_cull_result, int p_cull_count, PassMode p_pass_mode, bool p_using_sdfgi = false); | ||
|
|
||
| Map<Size2i, RID> sdfgi_framebuffer_size_cache; | ||
|
|
||
| bool low_end; |
There was a problem hiding this comment.
Remember to initialized member vars in the header.
There was a problem hiding this comment.
my bad, force pushing fix in a bit
reduz
force-pushed
the
reorganize-3d-render
branch
from
f6d2e01
to
1ac66bb
Compare
JFonS
approved these changes
Dec 7, 2020
-Reduce number of uniform sets from 6 to 4. -Remove features in low end mode, in order to reduce the number of texture units fit to 16.
reduz
force-pushed
the
reorganize-3d-render
branch
from
1ac66bb
to
2748b9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Reduce number of uniform sets from 6 to 4.
-Add a low end mode (default false, but true if running in mobile).
-Remove features in low end mode, in order to reduce the number of texture units fit to 16.