Fixes to recent Vulkan errors #44286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
commented
Dec 11, 2020
| @@ -14,7 +14,7 @@ layout(local_size_x = OCT_RES, local_size_y = OCT_RES, local_size_z = 1) in; | |||
| layout(rgba16f, set = 0, binding = 1) uniform restrict image2DArray irradiance_texture; | |||
| layout(rg16f, set = 0, binding = 2) uniform restrict image2DArray depth_texture; | |||
|
|
|||
| ayout(rgba32ui, set = 0, binding = 3) uniform restrict uimage2DArray irradiance_history_texture; | |||
| layout(rgba32ui, set = 0, binding = 3) uniform restrict uimage2DArray irradiance_history_texture; | |||
There was a problem hiding this comment.
Not really a bug, this entire file is never used
| @@ -2578,7 +2578,7 @@ RID RendererSceneRenderForward::_setup_render_pass_uniform_set(RID p_render_buff | |||
| RD::Uniform u; | |||
| u.binding = 12; | |||
| u.uniform_type = RD::UNIFORM_TYPE_UNIFORM_BUFFER; | |||
| u.ids.push_back(rb ? render_buffers_get_default_gi_probe_buffer() : render_buffers_get_gi_probe_buffer(p_render_buffers)); | |||
| u.ids.push_back(rb ? render_buffers_get_gi_probe_buffer(p_render_buffers) : render_buffers_get_default_gi_probe_buffer()); | |||
There was a problem hiding this comment.
Fixes bug when errors are spammed when using shadows (probably arises in other ways too)
| @@ -2500,7 +2500,7 @@ RID RendererSceneRenderForward::_setup_render_pass_uniform_set(RID p_render_buff | |||
| RD::Uniform u; | |||
| u.binding = 4; | |||
| u.uniform_type = RD::UNIFORM_TYPE_TEXTURE; | |||
| RID texture = false && rb && rb->depth.is_valid() ? rb->depth : storage->texture_rd_get_default(RendererStorageRD::DEFAULT_RD_TEXTURE_WHITE); | |||
| RID texture = rb && rb->depth.is_valid() ? rb->depth : storage->texture_rd_get_default(RendererStorageRD::DEFAULT_RD_TEXTURE_WHITE); | |||
reduz
approved these changes
Dec 15, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bugs introduced by #44175
Looks like SDFGI is still very broken. I explored it for a bit, but it was not obvious.