Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Range return 1.0 ratio if minimum and maximum values are equal #45220

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 15, 2021

An error message is also no longer printed. This matches the behavior found in most UI frameworks where having equal minimum and maximum values is considered acceptable.

This closes #43179.

An error message is also no longer printed.
This matches the behavior found in most UI frameworks where having
equal minimum and maximum values is considered acceptable.

This closes godotengine#43179.
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement needs testing topic:gui labels Jan 15, 2021
@Calinou Calinou added this to the 4.0 milestone Jan 15, 2021
@akien-mga akien-mga merged commit b84729f into godotengine:master Jan 26, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 26, 2021
@Calinou Calinou mentioned this pull request Mar 6, 2021
@Calinou Calinou deleted the range-ratio-equal-min-max-no-error branch March 31, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot get ratio when minimum and maximum value are equal"
2 participants