Add additional plugin path checks (3.2)

[Shatur]

Need for compatibility after #45316.
Fixes #46383.

[YuriSizov]

It works as expected now. Would it make sense to introduce a new method that sanitizes the input so that you don't repeat the checks manually everywhere?

[Shatur]

@pycbouh, agree, done.

[YuriSizov]

I thought p_addon.begins_with("res://") check would be a part of that method as well, so it actually sanitizes the value. Otherwise LGTM.

[Shatur]

I thought p_addon.begins_with("res://") check would be a part of that method as well, so it actually sanitizes the value.

I thought about it, but it would require making an extra copy of the String even if the path is the same. I know about COW in String, but this will not zero-cost.
Anyway, let me know if I should change it.

[coppolaemilio]

Did a build with the most recent changes and I get no error 👍🏻
Thanks for the quick turnaround!

[akien-mga]

Thanks!