Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enabling of created plugin #46670

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fix enabling of created plugin #46670

merged 1 commit into from
Mar 9, 2021

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Mar 4, 2021

Fixes #46560 for master branch.

@Calinou Calinou added this to the 4.0 milestone Mar 4, 2021
@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 4, 2021
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 5, 2021
@akien-mga
Copy link
Member

Should we add the same _to_addons_plugin_path() from #46389 in master too to make things clearer? I.e. apply the same changes as in 3.2, just without the actual back-compatibility check.

@Shatur
Copy link
Contributor Author

Shatur commented Mar 6, 2021

@akien-mga, agree, done.

@akien-mga akien-mga merged commit ca1db96 into godotengine:master Mar 9, 2021
@akien-mga
Copy link
Member

Thanks!

@Shatur Shatur deleted the fix-enable-created-plugin branch March 9, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:plugin
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Parsing the config failed warning popup when creating a plugin with Activate now enabled
3 participants
@Shatur @akien-mga @Calinou