Make LSP parser aware of variables in sub-blocks #47338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vnen has stated that he will fix ongoing issues with GDScript for 4.0, but given that is a ways away, he has noted that language server issues can still be fixed for 3.x.
Previously, the extended GDScript parser for the language server only looked at function blocks' surface without digging into sub blocks, like loops and if statements. That made hover requests fail, notably, though other look up tasks would also come up empty.
This PR makes it recursively get all of a function sub-blocks so that it can add their variables as part of the function's children.
Fixes #43164 and Fixes godotengine/godot-vscode-plugin#207