Implement LSP didDeleteFiles & make parser aware of sub-nodes #47776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward port of #47553 and #47338 which were created only for 3.x due to a miscommunication. This prevents double-fixing issues later, as was pointed out by akien. Future changes will be submitted to both 4.0 and 3.x where fitting.
The PR makes the language server implement the didDeleteFiles notification, which LSP clients can implement as of specifications 3.16.0, to clear diagnostics, and fixes the issue where variables being hovered or go-to-definition'ed when they were inside of a sub-block (if statement, for loop, while loop, match statement, etc) were not recognized as local symbols.
This fixes #43133, fixes #43164 and fixes #41449 .