Implement LSP didDeleteFiles to clear diagnostics #47553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the LSP specifications require, the language server is responsible for ownership of diagnostics. At the moment, when a file is deleted, nothing happens so errors persist even though they no longer exist.
Brings in a feature from the LSP 3.16.0 specifications for detecting file operations, namely
didDeleteFiles
, in the workspace. Clients that are not up to date to 3.16.0 spec will need to be updated to make use of it, but otherwise can be ignored by those that don't without issue.Fixes #43133