Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Script editor completion doesn't suggest members of a script for type hints #48037

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fix Script editor completion doesn't suggest members of a script for type hints #48037

merged 1 commit into from
Dec 12, 2022

Conversation

ray90514
Copy link
Contributor

Fix #47720
result:
example

@ray90514 ray90514 requested a review from a team as a code owner April 20, 2021 05:04
@Calinou Calinou added this to the 3.4 milestone Apr 20, 2021
@Calinou Calinou mentioned this pull request Apr 20, 2021
Closed
@vnen
Copy link
Member

vnen commented May 6, 2021

Ah, just realized this is for 3.x. The fix looks good to me, but is this issue fixed in master already?

@ray90514
Copy link
Contributor Author

ray90514 commented May 7, 2021 •
edited
Loading

Ah, just realized this is for 3.x. The fix looks good to me, but is this issue fixed in master already?

No, the same script running in master will caused a parse-error but not in 3.x, and the error message is
Parse Error: "scr" is a constant but does not contain a type.

@Chaosus Chaosus modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga requested a review from vnen July 2, 2022 22:49
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 2, 2022
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jul 2, 2022
@akien-mga akien-mga mentioned this pull request Dec 12, 2022
Closed
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Dec 12, 2022
akien-mga
akien-mga approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay!
Let's merge for 3.6 (and wait a bit for a potential 3.5.x cherry-pick to ensure there are no regressions).
I rebased the PR to make sure that it still compiles, since the last update was 18 months ago.

The bug this solves seems still valid in current 4.0 so this should be solved via a different PR.

@akien-mga akien-mga changed the title Fix Script editor completion doesn't suggest members of a script after : Fix Script editor completion doesn't suggest members of a script for type hints Dec 12, 2022
@akien-mga akien-mga merged commit 0e594bb into godotengine:3.x Dec 12, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.2.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 12, 2022
@0Volcanon 0Volcanon mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@vnen vnen Awaiting requested review from vnen

Assignees
No one assigned
Labels
bug topic:editor topic:gdscript
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ray90514 @vnen @akien-mga @Calinou @Chaosus