Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polygon rotation with batching #48457

Merged

Conversation

briansemrau
Copy link
Contributor

Fixes #48452

(Changes based on fix in #46898)

@lawnjelly
Copy link
Member

This looks correct, I forgot to change this at the same time as the rects. I just want to check there aren't any knock on effects like there were with the light angles (#47591) later today and test it out.

Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is fine, light angles aren't supported for polys at the moment so it goes through the legacy path if there are normal maps. And there's no large FVF support for lines.

Can confirm it fixes it for me too. 👍

@akien-mga akien-mga merged commit de3168f into godotengine:3.x May 4, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

@briansemrau briansemrau deleted the fix-polygon-rotation-batched branch May 17, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants