Set isGame flag as true on AndroidManifest

[lucasnlm]

Adds android:isGame to AndroidManifest.

[Calinou]

For reference, here's what the documentation says:

android:isGame

Whether or not the application is a game. The system may group together applications classifed as games or display them separately from other applications.

The default is false.

— https://developer.android.com/guide/topics/manifest/application-element

This is also used in the Android TV home screen: https://developer.android.com/training/tv/games/

We may want to expose this as an export preset setting (enabled by default), so that people can disable it if they're making non-game applications with Godot.

[akien-mga]

Could you amend the commit message to be more explicit about what the commit does?

[lucasnlm]

@akien-mga You mean change the commit message?
Updated to Set isGame flag as true on AndroidManifest

[akien-mga]

Seems good to me, but I'll let @m4gr3d review if this should be done as is or configurable as suggested by @Calinou. (Configurability could also be done later on if/when there's a need, and until then users can do custom builds and edit the manifest).

[m4gr3d]

I reached out internally, and the isGame attribute is not a reliable indication whether an app is a game or not. It's not respected by the Play store, and not used by the Android system.
In addition, Unity used to have a similar toggle for it and removed it since it didn't matter, so let's not add it as well.

@lucasnlm Even though we won't include it, we really appreciate your contribution and thanks for bringing this to our attention!

[akien-mga]

@m4gr3d I guess it might still be used by some Android-derived OSes that have game-specific categories in their launcher? I know my Pocophone F1's MIUI 12 has a Game category, though none of my installed games seem to be sorted in it.

Edit: The Android TV documentation mentions it as used to sort the app among games: https://developer.android.com/training/tv/games/index.html#manifest

Unity does seem to still have the isGame setting documented in their docs for 2020.3 LTS at least: https://docs.unity3d.com/Manual/android-manifest.html

It does sound like something that shouldn't hurt to enable for those launchers which do use this metadata? Otherwise I'd advise pushing internally for getting it marked as deprecated if there's no benefit to setting it: https://developer.android.com/guide/topics/manifest/application-element#isGame

[m4gr3d]

@akien-mga Thanks for the pointer to the Android TV documentation. It indeed sounds like it shouldn't hurt to give users the ability to set it if they want.

[m4gr3d]

@lucasnlm Based on @akien-mga's comment, it may be worth adding this feature, however this PR would have to be updated so that the feature is customizable by the user.
Is that something you'd feel comfortable doing? If not, feel free to close this PR and open an issue instead.

Thanks!

[m4gr3d]

The feature should be togglable.

[lucasnlm]

@m4gr3d I will try to implement it.

[akien-mga]

Superseded by #50028.