-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Add isGame
application attribute, default to true
#50028
Android: Add isGame
application attribute, default to true
#50028
Conversation
e7751fc
to
1e8816b
Compare
Tested with the prebuilt APK workflow and it works fine. However with custom build, it fails with:
I see that the |
Actually no, it's a pre-existing bug, it's just that nobody ever seems to set
|
It can be turned off in the export preset with `package/classify_as_game`. Upstream definition: https://developer.android.com/guide/topics/manifest/application-element#isGame > `android:isGame` > > Whether or not the application is a game. The system may group together > applications classifed as games or display them separately from other > applications. Also fixes replacing `android:allowBackup` in custom builds.
1e8816b
to
40a594c
Compare
Fixed the issues with custom builds, and I've tested a number of combinations successfully (prebuilt APK with and without |
Cherry-picked for 3.4. |
… cherry-pick The `android:icon` attribute is expected to be the last one in the application definition, as documented by the comment. cd64bcd missed that and caused some arguments to be truncated. Fixes godotengine#50224.
Android: Fix truncated `application` attributes after #50028 cherry-pick
It can be turned off in the export preset with
package/classify_as_game
.Upstream definition: https://developer.android.com/guide/topics/manifest/application-element#isGame
Supersedes #48547.
needs testing
as I haven't tested this code yet, just wrote it by analogy with theallowBackup
attribute.