Fix AnimationTree function call track loop #51576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember I had a similar problem before and solved it using a different method in #48332, but I don't know if it's the right way too. |
timothyqiu
added
the
cherrypick:3.x
This was referenced Nov 5, 2021
|
Superseded by #53819. |
akien-mga
added
archived
and removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50636.
If the animation does not loop, delta time should be set to zero if we're already at the end of the animation.
I'm pretty sure this fixes the cause of the issue. But I'm not 100% sure there is no other code that depends on the old behavior, it's odd that a stopped animation would revisit a method call keyframe repeatedly though.
For
3.x, this is basically the same except that time usesfloatinstead ofdouble.