-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement ping-pong animation and reverse playback #53819
Reimplement ping-pong animation and reverse playback #53819
Conversation
af17bc3
to
6a0a459
Compare
Seems that overhaul has largely finished, just FYI :) |
Ah it's not ready yet, I was pinged. |
6a0a459
to
953a7bc
Compare
@reduz @fire Rebased. I did a quick test using a previous project but Blendshape and compressed tracks were not tested (for some reason, the mesh instance with Blendshape crashes, and I don't know much about compression tracks in terms of how they are generated), but I believe that the code seems to be fine. |
Thanks! |
Can fix the bug of 3.X? |
We need to cherry-pick #51576 to fix #50636 and #54619. Ping @timothyqiu. |
Ah, I tested those issues and they were resolved by this PR. I thought this would be backported... Should I reopen my PR? |
This PR is large, so it is difficult to backport it. In particular, So, smaller fixes should be cherry-picked separately for 3.x. |
This is a resend of #48332.
Once approved before, but temporarily reverted due to conflicts with a huge overhaul of the animation features.
Until that overhaul is finished, it will be left as a draft PR to check and resolve conflicts.
Bugsquad edit: Fixes #50636. Fixes #54619. Supersedes #51576.