Implement camera orbiting shortcuts.

[rcorre]

Fixes godotengine/godot-proposals#2051.
Relates to godotengine/godot-proposals#1215.

Implements shortucts for adjusting the camera rotation in 15-degree
increments, similar to Blender.

I did not add corresponding menu entries for these, as I didn't feel
like they would be too useful from a menu, and didn't want to make the
menu too long.

[Calinou]

Tested locally (rebased against latest master), it works as expected.

[akien-mga]

Thanks!

[Calinou]

This PR can be cherry-picked to 3.x without conflicts. I tested it there as well and it works fine 🙂

I just noticed a minor issue when using the rotation shortcuts (both in master and 3.x). When you rotate the camera upwards or downwards, it can go upside down (which is probably fine). If you perform a full turn this way, the camera will suddenly snap back to its minimum/maximum pitch angle when panning or using freelook. We can fix this by using fmod() when setting the pitch angle, so that the angle actually wraps back to a normally accepted value when making a full turn.

Alternatively, we can clamp the shortcuts to the same pitch angle constraints as panning and freelook – or remove the pitch angle restrictions from panning and freelook, which would match Blender behavior.

[rcorre]

I'm on board with godotengine/godot-proposals#1371, but we could add fmod in the meanwhile if we're not sure that would be approved.

I tried testing this on main and while trying to see how the "normal" camera controls behave, I realized that holding MMB/RMB while moving the mouse doesn't seem to do anything in 4.0. Is that a bug?

[Calinou]

I realized that holding MMB/RMB while moving the mouse doesn't seem to do anything in 4.0. Is that a bug?

This is caused by #53894. Unfocus and focus the editor window again, and it should work.

[akien-mga]

Cherry-picked for 3.4.

[rcorre]

We can fix this by using fmod() when setting the pitch angle, so that the angle actually wraps back to a normally accepted value when making a full turn.

Do we actually want to wrap it, or just have it stop when it hits the min/max angle?

[Calinou]

Do we actually want to wrap it, or just have it stop when it hits the min/max angle?

Clamping the value is fine, but wrapping is required if we want to allow the camera to go upside-down when panning or using freelook.

For 3.4, I think we can just clamp the angle value when using the camera orbiting shortcuts. We can investigate what to do with panning and freelook in 3.5 and 4.0.