Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp rotation for up/down orbiting shortcuts. #54788

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Clamp rotation for up/down orbiting shortcuts. #54788

merged 1 commit into from
Nov 9, 2021

Conversation

rcorre
Copy link
Contributor

@rcorre rcorre commented Nov 8, 2021 •
edited
Loading

This prevents the viewport from going upside-down.

This was suggested at
#51984 (comment):

For 3.4, I think we can just clamp the angle value when using the
camera orbiting shortcuts. We can investigate what to do with panning
and freelook in 3.5 and 4.0.

@Calinou
Copy link
Member

Calinou commented Nov 8, 2021 •
edited
Loading

This is a good change, but the PR should be submitted to the master branch so it can be cherry-picked to 3.x and 3.4 later on. I don't think you can change the PR's base branch from GitHub here, so you likely have to close this PR and open a new one.

We can then look into improving the rotation behavior in master first, and cherry-pick that to 3.x (but not 3.4 as that branch will only receive bug fixes from now on).

@Calinou Calinou added this to the 3.4 milestone Nov 8, 2021
@rcorre rcorre changed the base branch from 3.4 to master November 9, 2021 11:42
@rcorre rcorre requested review from a team as code owners November 9, 2021 11:42
@rcorre rcorre requested a review from a team as a code owner November 9, 2021 11:45
Calinou
Calinou reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please update the commit message to remove the @Calinou mention. GitHub tends to notify mentioned users whenever a fork pushes upstream commits to its master branch, so I could end up getting a ton of notifications for no good reason 🙂

@rcorre
Clamp rotation for up/down orbiting shortcuts.
3bd7c4f 
This prevents the viewport from going upside-down.

This was suggested at:
godotengine#51984 (comment):

> For 3.4, I think we can just clamp the angle value when using the
> camera orbiting shortcuts. We can investigate what to do with panning
> and freelook in 3.5 and 4.0.
@akien-mga akien-mga modified the milestones: 3.4, 4.0 Nov 9, 2021
@akien-mga akien-mga added cherrypick:3.4 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Nov 9, 2021
@akien-mga akien-mga removed request for a team November 9, 2021 12:02
@akien-mga akien-mga merged commit eb98fd9 into godotengine:master Nov 9, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 15, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

@rcorre rcorre deleted the orbit_clamp branch November 16, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rcorre @Calinou @akien-mga