[3.x] added optional cropping for texture atlas importer #52652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Sep 14, 2021
| @@ -71,6 +71,7 @@ String ResourceImporterTextureAtlas::get_preset_name(int p_idx) const { | |||
| void ResourceImporterTextureAtlas::get_import_options(List<ImportOption> *r_options, int p_preset) const { | |||
| r_options->push_back(ImportOption(PropertyInfo(Variant::STRING, "atlas_file", PROPERTY_HINT_SAVE_FILE, "*.png"), "")); | |||
| r_options->push_back(ImportOption(PropertyInfo(Variant::INT, "import_mode", PROPERTY_HINT_ENUM, "Region,Mesh2D"), 0)); | |||
| r_options->push_back(ImportOption(PropertyInfo(Variant::BOOL, "cropped"), false)); | |||
There was a problem hiding this comment.
Would it be clearer if the option was named crop_to_region or something like that?
boruok
force-pushed
the
optional-crop-for-texture-atlas-importer
branch
from
e7dbea2 to
9913af9
Compare
akien-mga
changed the title
|
Code looks good to me, I just need to get the feature itself validated by import folks and we can merge. This should probably have a |
|
The proposal describes a real use. Will wait for the master branch pr. |
reduz
approved these changes
Oct 5, 2021
|
Thanks! Merging already for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added optional region cropping to Texture Atlas importer. See godotengine/godot-proposals#1661
this is my second try of #52564, sorry, first ever PR. Let me know if did anything wrong.