Disable sub-inspectors for properties with their own editors #52984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for some problems with multiple contextual editors (namely #52779, #29873, #47514). The proper fix is #45085, but it's for master and reduz wants to overhaul the system anyway.
But we still have problems in 3.x, including quite critical regressions for the upcoming 3.4 (#52779). So I propose this as a solution to make sure 3.x is in a working state. Since sub-inspectors are broken when multiple editors are involved, this PR disables sub-inspectors in such cases. We already have editors that force their edited resource to be opened in a new inspector instead of a sub-inspector (e.g. the TileSet editor), so this should be fine for the time being.
Linked issues should probably not be closed until #45085 or a new alternative is implemented.