Reload kinematic shapes when changing PhysicsBody mode to Kinematic

[BimDav]

This complements the PR #51857, as there is still a crash when changing the mode to Kinematic.

Reload kinematic shapes when changing PhysicsBody mode to Kinematic to prevent a crash when calling test_body_motion.
Call reload_kinematic_shapes from init_kinematic_utilities as they are always called together.

Bugsquad edit: Fixes #53125.

[BimDav]

Fixes #53125

[pouleyKetchoupp]

Thanks for finding the issue and fixing it!

It looks great. I was just wondering, why did you decide to revert the change to avoid calling init_kinematic_utilities() directly when switching to Kinematic mode? Was it causing issues in some cases?

[BimDav]

It looks great. I was just wondering, why did you decide to revert the change to avoid calling init_kinematic_utilities() directly when switching to Kinematic mode? Was it causing issues in some cases?

It don't think it causes issues either way but I think that the majority of cases for a PhysicsBody in Kinematic mode may be the KinematicBody nodes. So in that case, I think it makes more sense to initialize everything needed by kinematic methods at the body's initialization, not at the first call of a kinematic method. It was also one less change so I thought it was less risky. But either way is OK with me!

[pouleyKetchoupp]

It looks great. I was just wondering, why did you decide to revert the change to avoid calling init_kinematic_utilities() directly when switching to Kinematic mode? Was it causing issues in some cases?

It don't think it causes issues either way but I think that the majority of cases for a PhysicsBody in Kinematic mode may be the KinematicBody nodes. So in that case, I think it makes more sense to initialize everything needed by kinematic methods at the body's initialization, not at the first call of a kinematic method. It was also one less change so I thought it was less risky. But either way is OK with me!

Alright, sounds good to me then :) It does make sense to just focus on fixing the crash in this PR.

[pouleyKetchoupp]

Congrats on your first merged PR!

[akien-mga]

Cherry-picked for 3.4.