Added primary clipboard for Linux #53702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulb23
requested changes
Oct 12, 2021
ConteZero
force-pushed
the
primary_clipboard_linux
branch
5 times, most recently
from
c1f6470
to
8098535
Compare
|
@Paulb23 I've done some changes in how primary clipboard selection is handled to solve a bug in the previous code. |
Paulb23
requested changes
Oct 16, 2021
ConteZero
force-pushed
the
primary_clipboard_linux
branch
from
8098535
to
f40eb7f
Compare
|
@Paulb23 I've also added a missing update() in rich_text_label |
ConteZero
force-pushed
the
primary_clipboard_linux
branch
from
f40eb7f
to
fcabdb0
Compare
akien-mga
reviewed
Oct 18, 2021
ConteZero
force-pushed
the
primary_clipboard_linux
branch
from
fcabdb0
to
838c9d3
Compare
akien-mga
approved these changes
Oct 18, 2021
|
I would like to send a pull request for the 3.x branch to backport this feature, can I do it or should I wait for this one to be merged? |
You can open a |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
@ConteZero good job! Thanks for picking it up again 🤘🔥💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add support for primary clipboard on Linux to handle text paste with middle mouse button.
It should solve #3030
This is based on code originally written by @larpon, I fixed some bugs, added small improvements and updated the code to make it work with current master branch.
Bugsquad edit: Fixes godotengine/godot-proposals#3440.