Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALT NUM+ {hex code} character input support for LineEdit, TextEdit and CodeEdit. #55441

Merged
merged 1 commit into from
May 13, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 29, 2021

Implements #2689

To use, press and hold the ALT (Option) key, press and release the numpad plus key, type a hexadecimal Unicode character code, then release the ALT key.

@Paulb23
Copy link
Member

Paulb23 commented Dec 1, 2021

Shouldn't this be restricted to Windows?

@Calinou
Copy link
Member

Calinou commented Dec 1, 2021

Shouldn't this be restricted to Windows?

Judging how #53702 is restricted to X11, it makes sense to restrict this feature to Windows.

On other operating systems, I suppose third-party utilities that implement similar functionality would be configured to be effective in every application anyway.

@bruvzg
Copy link
Member Author

bruvzg commented Dec 1, 2021

Shouldn't this be restricted to Windows?

Maybe. For example, on macOS, a similar feature is implemented as the special keyboard layout. On the other hand, it was requested in this issue - #55410, which mention Linux. If it's not conflicting with anything, it might be useful anywhere.

@akien-mga
Copy link
Member

Sorry for the delay. I think the implementation makes sense as is, might need a rebase though to be sure it still builds fine.

@akien-mga akien-mga merged commit 498cdc2 into godotengine:master May 13, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants