glTF: Cleanup includes and defines, split PackedSceneGLTF to own file #55859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
3.x-gltf-module-cleanup
branch
from
fd34ccc to
e4c40d8
Compare
fire
approved these changes
Dec 12, 2021
Yeah it should be pretty safe if it compiles, I didn't change any of the module's logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #55796 (comment) I noticed a lot of pointless includes in the glTF module (despite having fixed many of those in the past already), so I jumped in the rabbit hole and did a full cleanup.
I'll have a look at porting the same changes to
master(when relevant) later on.