Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS export] Improve code signing/notarization options validation. #56665

Merged
merged 1 commit into from
Jan 10, 2022
Merged

[macOS export] Improve code signing/notarization options validation. #56665

merged 1 commit into from
Jan 10, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 10, 2022

Adds warning for incompatible and non-optimal configs.
Automatically ignore hardened runtime and timestamp when using ad-hoc signature.

Screenshot 2022-01-10 at 13 16 23

Fixes #56392

@bruvzg bruvzg added this to the 4.0 milestone Jan 10, 2022
@bruvzg bruvzg requested a review from a team as a code owner January 10, 2022 11:21
@akien-mga akien-mga merged commit b2f5c56 into godotengine:master Jan 10, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg mentioned this pull request Jan 31, 2022
Open
@bruvzg bruvzg deleted the macos_export_options branch January 31, 2022 18:12
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 31, 2022
@akien-mga
Copy link
Member

@bruvzg I've had a look at cherry-picking this for 3.x to help with #57455, but it seems the 3.x is in an intermediate state where some of this code has been backported (likely in 30ee208) but not all of it. This might warrant a dedicated backport PR.

@bruvzg
Copy link
Member Author

bruvzg commented Jan 31, 2022

This might warrant a dedicated backport PR.

#51550 should already have all relevant changes.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos topic:export usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[Mono] Using DateTime.Now causes crash on MacOS Monterey in exported project
2 participants
@bruvzg @akien-mga