Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Joint2D and Joint: update joint on NOTIFICATION_POST_ENTER_TREE #58642

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

rburing
Copy link
Member

@rburing rburing commented Feb 28, 2022

In contrast with updating only on NOTIFICATION_READY, this allows reparenting, etc.

Fixes #31711 and fixes #41398 in 3.x.

Also fixes a related issue (in a separate commit): makes set_exclude_nodes_from_collision respect signal connections.

This is the 3.x version of #58641.

@akien-mga akien-mga merged commit 29d78f2 into godotengine:3.x Mar 1, 2022
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the joints_fix_signals_3.x branch March 1, 2022 10:03
@akien-mga
Copy link
Member

Cherry-picked for 3.4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants