Improve TextureRegionEditor #61429
Merged
Improve TextureRegionEditor #61429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
May 26, 2022
| hscroll->set_value((hscroll->get_min() + hscroll->get_max() - hscroll->get_page()) / 2); | ||
| vscroll->set_value((vscroll->get_min() + vscroll->get_max() - vscroll->get_page()) / 2); | ||
| // This ensures that the view is updated correctly. | ||
| callable_bind(callable_mp(this, &TextureRegionEditor::_pan_callback), Vector2(1, 0)).call_deferred(nullptr, 0); |
There was a problem hiding this comment.
I can't believe centering on the texture was so difficult. I resorted to this hack, anything better would require some bigger rewrite of the scroll logic.
One of the problems was that the scrollbars are initialized to their final value after a second update, hence the hscroll->get_min() < 0 part.
reduz
approved these changes
May 26, 2022
|
looks great to me! |
|
Is there a reason not to always use the percentage rather than the relative unit for zooming? |
fire-forge
reviewed
May 26, 2022
akien-mga
approved these changes
May 26, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #61342