Reorganize Region Rect Editor #61342
Conversation
|
The editor should automatically center the texture whenever opened. Right now it opens in top-left corner for the first time. The window is super big, you don't have live preview when editing the region (unless you have a second screen). It should be probably smaller. Also it might be helpful to display some faint borders to denote texture's size. |
|
@KoBeWi makes sense. I did not modify the editor itself though, just put it in a window. I think improvements to the editor could happen on a separate PR. |
Problem: * Region rect was pretty much a hidden editor. Because it was annoying for it to pop up automatically, it did not. * Because it did not, most users have no idea it even exists. * But because it is a transient editor, it would steal focus of other editor and annoy users. Solution: * Editor has been moved to a window. * Regions that can be edited add a button below the region which can be pressed to open the editor. This required a slight change in EditorInspectorPlugin to allow custom editors to be below others.
reduz
force-pushed
the
reorganize-region-rect-editor
branch
from
2478f5b
to
4044cc7
Compare
|
Instead of the small button on the left, make the entire "Edit Region" thing a button? And perhaps rename it "Region Editor" to be consistent? |
I think it is already the case. The icon is just ragged left. |
That's not good, because any shortcoming of that switch is now a usability regression. The editor moved from a small panel to a huge window, so you get this: |
| region_editor->snap_mode_button->select(state["snap_mode"]); | ||
| bool EditorInspectorPluginTextureRegion::parse_property(Object *p_object, const Variant::Type p_type, const String &p_path, const PropertyHint p_hint, const String &p_hint_text, const uint32_t p_usage, const bool p_wide) { | ||
| if ((p_type == Variant::RECT2 || p_type == Variant::RECT2I)) { | ||
| if (((Object::cast_to<Sprite2D>(p_object) || Object::cast_to<Sprite3D>(p_object) || Object::cast_to<NinePatchRect>(p_object) || Object::cast_to<StyleBoxTexture>(p_object)) && p_path == "region_rect") || (Object::cast_to<AtlasTexture>(p_object) && p_path == "region")) { |
There was a problem hiding this comment.
Checking property of StyleBoxTexture is not necessary, as region_rect is the only Rect2 property in there.
This is a little bit exaggerated. On your screen the new window is maybe twice the height of what would be the bottom panel, so it does not go from small to huge, but from already too big to huge. So I would not call that a regression. I think a simple fix would be to popup with a smaller size for now (like 50% of the editor window instead of the default value, or even automatically computed according to the texture size), but I agree the texture should be centered if possible too. |
Yeah but the window appears over the 2D editor and covers the whole viewport. Panel didn't have this problem.
That's what I suggested in my first comment, but then this got merged :v |
Oh my bad, I though the commit pushed by reduz after your comment addressed your feedback. :/ |
|
@KoBeWi I can do some fixes later if you wish (or you can PR them to use a smaller window ratio or further improvements). But I needed to merge this to work on the shader editor. But in any case, I think changing how the window pops up should be enough. |
|
A button in the inspector to open a floating window is exactly how I thought it should be. The only problem I see is that the button looks just like another label in the inspector, not like a button. This could hinder discoverability. |
|
@neikeq I agree, but we are using all buttons like this in the inspector for everything so I did not want to make it different. We really need to discuss how to improve the readability. |
|
Is something like this better? |
|
@KoBeWi I suppose its better, but you should check other buttons, like Add Metadata and the ones for array management so we use something unified. |
Problem:
In general, Region Rect editor is a very weird editor, because it only edits the single region_rect property of objects that read a texture from a region, no other editor works quite like it.
Solution:
Because of the strange nature of this editor, a dedicated solution was implemented:
This required a slight change in EditorInspectorPlugin to allow custom editors to be below others.
How it looks in action:
Regions now have a button you can press to edit them:
This opens the region editor in context, only when you need it:
What it fixes:
Fixes #28341
Fixes #47514
Fixes #29873
And probably many others.