Expose the current animation tree and player to AnimationNode #61458
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes the `tree` and `player` members of `AnimationNode::State` available in C++ to scripts, enabling their use in custom nodes. Without this various obtuse and potentially problematic workarounds are required. For example, with this patch, the following code can be changed from this (which has undesired side effects): ```gdscript # seek the animation to its beginning, which will cause `blend_node` to # return its length duration = blend_node(animation_node_name, animation_node, 0.0, true, false, 0.0, AnimationNode.FILTER_IGNORE, true) ``` To the more obvious and direct form: ```gdscript duration = get_player().get_animation(animation_name).length ```
maiself
force-pushed
the
expose-tree-and-player-to-animation-node
branch
from
bd1c07b to
53930d4
Compare
|
There is related issue as #23629 (comment); this PR means accessing a scene from a resource, which may cause problems when there are multiple scenes that use the same animation. |
|
Please make a proposal, justifying the need for this feature. Perhaps in a discussion a less problematic implementation can be figured out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the
treeandplayermembers ofAnimationNode::Stateavailable in C++ to scripts, enabling their use in custom nodes.Without this various obtuse and potentially problematic workarounds are required.
For example, with this patch, the following code can be changed from this (which has undesired side effects):
To the more obvious and direct form: