-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Font configuration and import UI, and Font resources. #62108
Conversation
Can font size be changed for per control node? |
It's already possible with the Theme properties and not changed by this PR. |
ea64688
to
cb56389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, but I have the feeling that using FontBase all across the codebase probably is a bit unnecesary since we don't do this with other resource types (like Texture2D, AudioStream, Mesh, etc).
Maybe we should do
FontBase -> Font (abstract)
Font -> FontFile or VectorFont or maybe just ScalableFont (which is the technical name for OTF/TTF/etc).
OK, I'll change it to |
@bruvzg Alright, sorry for the change request and great job!, realized we were no longer using resources with "Base" naming in 4.0 too late so my mistake. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks! |
Supersede #61406, Supersede #61473, Supersede #62065
Font
andFontData
into single Font resource. Including fallback font list and pre-rendered glyphs (different sets of pre-rendered glyphs can be selected for different sizes/variations).FontVariation
subclass to access OpenType variations, embolden/slant, font collection face index, OpenType features, and extra spacing and allow fallback override in runtime.New font resources structure:
FontVariation
screenshot: