Enable FXAA by default on viewports #63470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to higher-quality 3D visuals out of the box with a low performance impact. This change only affects 3D rendering.
|
I don't agree with this. FXAA is a hack and the only advantage of it is its cheapness. It underaliases many types of textures and it does not solve the actual problem which is temporal aliasing. |
|
Ideally we may want to have TAA enabled by default after its properly optimized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to higher-quality 3D visuals out of the box with a low performance impact. See godotengine/godot-proposals#4832 for comparison screenshots.
This change only affects 3D rendering. I've tested 2D rendering in a simple scene and can confirm there is no performance impact whatsoever when no Camera3D is present and active in the scene.
This closes godotengine/godot-proposals#4832 and partially addresses #53534.