Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default preview tonemapper to ACES #78106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atirut-w
Copy link
Contributor

This is just something based on my preferences, but another excuse reason is that ACES seems to be the new standard now, considering that it's more accurate than Filmic.

@atirut-w atirut-w requested a review from a team as a code owner June 11, 2023 04:55
@clayjohn clayjohn added this to the 4.x milestone Jun 11, 2023
@Saul2022
Copy link

I would disagree, while ACES may be a standard, it may be bad for people that wants more flexibility by default as filmic can give a better control while ACES is more for realistic games or engines like UE, and most users don't do realistic things here.

@atirut-w
Copy link
Contributor Author

filmic can give a better control while ACES

How so? From what I've seen, the options are the same in 4.x with only exposure and white point settings for both of them.

@Saul2022
Copy link

How so? From what I've seen, the options are the same in 4.x with only exposure and white point settings for both of them.

I mean artisticamly, as ACES has more contrast values that are more oriented in realism.

@AThousandShips
Copy link
Member

I'm not sure it's such a good idea to use a more resource intensive mode by default like this

@mrjustaguy
Copy link
Contributor

ACES is barely more resource intensive.. I think FXAA is significantly more expensive, and that'll be default if #63470 is merged, not to mention glow is 10 times more expensive and it is on by default if I remember correctly

@Calinou
Copy link
Member

Calinou commented Jun 11, 2023

See #49736 which also changes the tonemapper.

ACES is definitely more resource-intensive than other tonemappers, but not by much. That said, this can be an issue on slow integrated graphics or mobile, so I'm having second thoughts about using ACES by default. I think we should stick to Filmic but use a whitepoint of 6 (Filmic with a whitepoint of 1 doesn't make much sense).

ACES also has a notorious issue where it tends to make dark areas even darker, which some people dislike. Filmic is more neutral about this in comparison.

@Saul2022
Copy link

ACES is definitely more resource-intensive than other tonemappers, but not by much. That said, this can be an issue on slow integrated graphics or mobile, so I'm having second thoughts about using ACES by default. I think we should stick to Filmic but use a whitepoint of 6 (Filmic with a whitepoint of 1 doesn't make much sense).

Or you can add ACES to the forward+ renderer only as it the most expensive renderer with sdfgi and it stuff.

@Calinou
Copy link
Member

Calinou commented Jun 12, 2023

Or you can add ACES to the forward+ renderer only as it the most expensive renderer with sdfgi and it stuff.

Just because you use Forward+ doesn't mean you have a fast GPU that can handle SDFGI. Not everyone will use SDFGI when using Forward+ either, even if their GPU is fast enough. It's not the only reason to use Forward+, far from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants