Introduce appCategory attribute of android to set category

[qianjunakasumi]

According to android documentation (https://developer.android.com/guide/topics/manifest/application-element#isGame), android:isGame is deprecated.
To accommodate this change, use the appCategory attribute set to game.

: )

Considering that godot may also run on a lower version of android (because of minSDK), so the isGame attribute not delete.

Personally think: the change is compatible with 3.x.

[akien-mga]

Exposing appCategory makes sense, but it needs more work to be done properly. Not all Godot projects are game so like isGame, it needs to be configurable in the export preset. See #50028 for how isGame support was implemented.

There are two options, either we keep the current classify_as_game preset option and use it to set both isGame and appCategory=game, or we add a new app_category preset option with the full enum from https://developer.android.com/guide/topics/manifest/application-element#appCategory so users can select any value.

[m4gr3d]

There are two options, either we keep the current classify_as_game preset option and use it to set both isGame and appCategory=game, or we add a new app_category preset option with the full enum from https://developer.android.com/guide/topics/manifest/application-element#appCategory so users can select any value.

We should go with the new app_category preset. That would break compatibility so we can either only use that option for the master branch, or go forward with it for the 3.6 release.

[fire-forge]

What I think should be done is replacing the classify_as_game export option with an enum for setting appCategory with all of the available enum values, and setting isGame to true or false depending on if the category setting is "game, for backwards compatibility with older versions of Android. The default value can be "game" since most projects will be games, but then there's more flexibility for anyone who is making something other than a game.

[qianjunakasumi]

Thank you for your suggestions. Now I have written most of the code and it looks good in the compiled editor. I'm testing its export product .apk and will push it for review as soon as I feel the time is right.

[qianjunakasumi]

When trying the export type Accessibility, I found that android:appCategory cannot display the corresponding string android:appCategory: accessibility normally (android:appCategory: 8).

I have made some efforts but cannot change this problem, so I submit it and hope to get help.
Any help is appreciated!

[qianjunakasumi]

After a moment of searching, there doesn't seem to be any solution to the previous problem.
To make use of this enhancement as soon as possible, I took the liberty of removing accessibility appCategory, as it doesn't seem to fit the target category of the godot engine well.

Now it works fine and could merges into master
If you have a good idea, I'd appreciate it!

[m4gr3d]

When trying the export type Accessibility, I found that android:appCategory cannot display the corresponding string android:appCategory: accessibility normally (android:appCategory: 8).

I have made some efforts but cannot change this problem, so I submit it and hope to get help. Any help is appreciated!

Shouldn't the value for the accessibility category be 0 instead of 8 based on the ordering in the documentation?
Can you show the error you're running into when setting accessibility as the app category.

[qianjunakasumi]

Shouldn't the value for the accessibility category be 0 instead of 8 based on the ordering in the documentation?

Actually, it's 0 in the document. However, when getting the corresponding category according to the index, founding that the serial numbers were in a jumbled order. I have no idea how it actually work, so I wrote a function that maps a fake index to a real one

It is very strange that no matter how I order them, there is always an index corresponding to a category that does not display properly, guessing maybe the enumeration can only hold 8 objects? It looks good when there are only 8 objects.

[m4gr3d]

I tested with 'Accessibility' using the value 8 and it seems to work as expected.
The compiled manifest doesn't show the string, but shows the value assigned to them (which can be validated using the custom build).

So it should be safe to reintroduce the Accessibility category, and assign it with a value of 8.

[qianjunakasumi]

The compiled manifest doesn't show the string, but shows the value assigned to them (which can be validated using the custom build).

Like this, it's not the same as the other categories (android:appCategory="game") and maybe it's a bug ?🤔, I have no idea on how to fix it.

[m4gr3d]

@qianjunakasumi Can you squash the commits.

[m4gr3d]

The changes look good, and the logic works as expected (based on my own testing) so this PR is good to go.

As mentioned, once you squash the commits, this should be ready to merge.

[qianjunakasumi]

@qianjunakasumi Can you squash the commits.

sure, ptal :)

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉