Fix VS project creation

[afestini]

Fixes #66664.

The introduction of a dev option created a mismatch between number of build targets and variants, causing the VS project creation to fail.

PR creates the missing variants for dev/non-dev.

[akien-mga]

Our python formatter (black with line length configured to 120) wants the long line wrapped: https://github.com/godotengine/godot/actions/runs/3165660414/jobs/5155026483

I'd suggest moving the length calculation to a local variable to keep it to 2 lines instead of what the formatter wants to do here.

Please edit the commit with git commit --amend when fixing it.

[afestini]

Done. Glad I'm not the only one that prefers to avoid line breaks (even more so in Python).
I was going for "variant_count", to make it clearer, but the indentation level only allowed for "count". Given how short the function is, it should still be clear enough.

[TechnoPorg]

Maybe vsproj=yes should be added to the GitHub Windows builds, to prevent future regressions of this nature?

[afestini]

Changed the logic after running into a problem with binary output names. Names were created for dev_build=yes and =no, but since variant names were identical and collapsed to only 3, the binary would always be named .dev, even for non-dev builds.

The new version only creates the names needed depending on whether dev_build is set or not, rather than creating duplicate variants that get filtered out by VS. It seems like the NMake command line is also only based on the env variable.

A cleaner fix could involve:
-create NMake command line individually for each variant (right now it's just duplicated, since it was generic enough to work for all combinations until dev_build entered the picture)

-make "dev" part of the variant names, increasing the number from 3 to 6 configurations (if it doesn't create any issues in other parts).

[akien-mga]

That seems fine if that's the expected workflow for VS users. I never use it so I don't know which is preferred.

My intention was that users would be able to select whether they want to build and run a dev build from a drop-down list, like they can choose if they want to build the editor, release template or debug template, i.e.:

• Editor
• Editor (dev build)
• Debug template
• Debug template (dev build)
• Release template
• Release template (dev build)

And thus, like target, or tools before the refactoring, the value of dev_build passed together with vsproj wouldn't matter.

But I'm also fine with the current solution for the time being, we can reassess if users do want something like what I list above.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[afestini]

Those six options were my first attempt, but as Eric pointed out, that is causing issues. There seem to be some unexpected dependencies on the names. I also have to correct myself on duplicating the command line after trying to figure out how to create different ones. I only see the one and cmdargs seems to be the way to pass different additional options to scons.

So I agree that this is more of a hotfix. If handling all 6 configs can be done with relatively small changes, I might open another PR, but I'm hesitant to mess around too much without a deeper understanding how the whole build system works together (especially across platforms I don't have and can't test).