Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix Array.Shuffle incorrect mono bindings #68252

Merged
merged 1 commit into from
Nov 9, 2022
Merged

[3.x] Fix Array.Shuffle incorrect mono bindings #68252

merged 1 commit into from
Nov 9, 2022

Conversation

dzil123
Copy link
Contributor

@dzil123 dzil123 commented Nov 4, 2022

Fixes #60840

@dzil123 dzil123 changed the title [3.x] Fix Array.Shuffle incorrect bindings [3.x] Fix Array.Shuffle incorrect mono bindings Nov 4, 2022
@akien-mga akien-mga added bug topic:dotnet cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Nov 4, 2022
@akien-mga akien-mga added this to the 3.6 milestone Nov 4, 2022
@akien-mga
Copy link
Member

Is this need in 4.0 too or are the bindings correct there?

@dzil123 dzil123 mentioned this pull request Nov 4, 2022
Merged
@dzil123
Copy link
Contributor Author

dzil123 commented Nov 4, 2022 •
edited
Loading

The crash only occurs in 3.x javascript.
4.0 does not have mono for web implemented yet, so I don't know if this same bug would happen there.

I suspect that the internal static extern signature mismatch is not causing the crash, but I haven't tested it by itself.

@akien-mga akien-mga merged commit 09b4c69 into godotengine:3.x Nov 9, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Nov 9, 2022
Closed
@timothyqiu
Copy link
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@neikeq neikeq neikeq approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@dzil123 @akien-mga @timothyqiu @neikeq