Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix Array.Shuffle incorrect mono bindings #68252

Merged
merged 1 commit into from
Nov 9, 2022
Merged

[3.x] Fix Array.Shuffle incorrect mono bindings #68252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/mono/glue/GodotSharp/GodotSharp/Core/Array.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ public override string ToString()
internal static extern Error godot_icall_Array_Resize(IntPtr ptr, int newSize);

[MethodImpl(MethodImplOptions.InternalCall)]
internal static extern Error godot_icall_Array_Shuffle(IntPtr ptr);
internal static extern void godot_icall_Array_Shuffle(IntPtr ptr);

[MethodImpl(MethodImplOptions.InternalCall)]
internal static extern void godot_icall_Array_Generic_GetElementTypeInfo(Type elemType, out int elemTypeEncoding, out IntPtr elemTypeClass);
Expand Down
2 changes: 2 additions & 0 deletions modules/mono/glue/collections_glue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ void godot_icall_Array_RemoveAt(Array *ptr, int index);

int32_t godot_icall_Array_Resize(Array *ptr, int new_size);

void godot_icall_Array_Shuffle(Array *ptr);

void godot_icall_Array_Generic_GetElementTypeInfo(MonoReflectionType *refltype, uint32_t *type_encoding, GDMonoClass **type_class);

MonoString *godot_icall_Array_ToString(Array *ptr);
Expand Down