[3.x] Fix CanvasLayer visibility toggle can only run once per frame #69558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
added
bug
topic:2d
cherrypick:3.5
timothyqiu
changed the title
|
Why does it work in CanvasItem despite the flag? |
|
In CanvasItem it's calling a different method without arguments (although the group name is the same). |
akien-mga
approved these changes
Dec 11, 2022
|
Thanks! |
|
Cherry-picked for 3.5.2 |
timothyqiu
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69556
The
GROUP_CALL_UNIQUEflag was copied fromCanvasItemcode.godot/scene/2d/canvas_item.cpp
Line 539 in 01574a5
I thought calling the same method with different arguments are considered unique calls, but it turns out I'm wrong :(