Add support for creating tiles when adding multiple atlases to a tileset #70790
Conversation
jamesmintram
changed the title
|
|
||
| void TileSetAtlasSourceEditor::_auto_create_tiles(Vector<Ref<TileSetAtlasSource>> const &new_tile_set_atlas_sources) { | ||
|
|
||
| Ref<EditorUndoRedoManager> &undo_redo = EditorNode::get_undo_redo(); |
There was a problem hiding this comment.
Single undo scope for all tile generation
jamesmintram
force-pushed
the
jamesm/feat/auto-create-tilesets-for-multiple-on-drop
branch
from
6a9b1ef
to
3fd152b
Compare
| @@ -259,7 +259,9 @@ class TileSetAtlasSourceEditor : public HSplitContainer { | |||
| void _unhandled_key_input(const Ref<InputEvent> &p_event); | |||
|
|
|||
| // -- Misc -- | |||
| void _auto_create_tiles(Vector<Ref<TileSetAtlasSource>> const &new_tile_set_atlas_sources); | |||
There was a problem hiding this comment.
Should be const Vector<...> &, and the parameter should start with p_.
jamesmintram
force-pushed
the
jamesm/feat/auto-create-tilesets-for-multiple-on-drop
branch
from
3fd152b
to
a6e2d49
Compare
jamesmintram
changed the title
jamesmintram
force-pushed
the
jamesm/feat/auto-create-tilesets-for-multiple-on-drop
branch
from
72375e2
to
5350237
Compare
|
Video of the changes in action, note the Undo error that appears is a pre-existing issue and (probably) out of scope for this change:
|
jamesmintram
force-pushed
the
jamesm/feat/auto-create-tilesets-for-multiple-on-drop
branch
from
5350237
to
82fa415
Compare
| @@ -119,6 +119,8 @@ class TileSetAtlasSourceEditor : public HSplitContainer { | |||
|
|
|||
| bool tile_set_changed_needs_update = false; | |||
|
|
|||
| Vector<Ref<TileSetAtlasSource>> pendingAtlases; | |||
There was a problem hiding this comment.
Please use snake_case for identifiers. You might see from surrounding code that we never use camelCase ;)
| @@ -275,7 +279,7 @@ class TileSetAtlasSourceEditor : public HSplitContainer { | |||
|
|
|||
| public: | |||
| void edit(Ref<TileSet> p_tile_set, TileSetAtlasSource *p_tile_set_source, int p_source_id); | |||
| void init_source(); | |||
| void init_sources(Vector<Ref<TileSetAtlasSource>> newSources); | |||
There was a problem hiding this comment.
| void init_sources(Vector<Ref<TileSetAtlasSource>> newSources); | |
| void init_sources(Vector<Ref<TileSetAtlasSource>> p_new_sources); |
|
I think the idea is fine. The implementation looks correct enough, but as the popup and automatic creation of tiles would not depends anymore on the currently edited atlas source, the logic to create those tiles should be moved outside of |
|
Hello @jamesmintram, thanks for making the PR! Would you be up to make the latest requested changes or do you want someone else to take over? Fixes #69273 |
|
Superseded by #79678. |
Adds support for "batch" creating tiles when dragging multiple atlases into a tileset. See: #69273